Wasmtime GitHub notifications bot (Feb 21 2025 at 00:13): Wasmtime GitHub notifications bot (Feb 21 2025 at 00:13):abrown opened PR #10266 from abrown:assembler-path-separator to bytecodealliance:main:
The new assembler uses
:to separate a list of paths containing generated code. We received a report that on Windows this could lead to build issues; this change uses;for Windows instead.prtest:full
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 21 2025 at 00:13):abrown requested wasmtime-compiler-reviewers for a review on PR #10266.
Wasmtime GitHub notifications bot (Feb 21 2025 at 00:13):abrown requested cfallin for a review on PR #10266.
Wasmtime GitHub notifications bot (Feb 21 2025 at 00:16):abrown commented on PR #10266:
It's still pretty unclear to me how this could have got past our Windows CI...
Wasmtime GitHub notifications bot (Feb 21 2025 at 00:22):abrown commented on PR #10266:
Perhaps something like the following is "fixing up" the paths?
Wasmtime GitHub notifications bot (Feb 21 2025 at 00:31):cfallin submitted PR review.
Wasmtime GitHub notifications bot (Feb 21 2025 at 00:33):alexcrichton commented on PR #10266:
This may technically still be broken in cross compilation scenarios due to the os of the build script differing from the os of the target. To sidestep all encoding issues could the array be generated in a rust file in the build script which is included with a macro?
Wasmtime GitHub notifications bot (Feb 21 2025 at 00:33):abrown has enabled auto merge for PR #10266.
Wasmtime GitHub notifications bot (Feb 21 2025 at 15:33):alexcrichton closed without merge PR #10266.
Wasmtime GitHub notifications bot (Feb 21 2025 at 15:33):alexcrichton commented on PR #10266:
Superseded by https://github.com/bytecodealliance/wasmtime/pull/10267
Last updated: Feb 28 2025 at 02:27 UTC