Stream: git-wasmtime

Topic: wasmtime / PR #10247 Winch: Add SIMD float arithmetic sup...

Wasmtime GitHub notifications bot (Feb 19 2025 at 21:03):

jeffcharles opened PR #10247 from jeffcharles:winch-simd-float-arith to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #8093. Adds implementations for:

• f32x4.add
• f64x2.add
• f32x4.sub
• f64x2.sub
• f32x4.mul
• f64x2.mul
• f32x4.div
• f64x2.div
• f32x4.neg
• f64x2.neg
• f32x4.sqrt
• f64x2.sqrt

Wasmtime GitHub notifications bot (Feb 19 2025 at 21:03):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10247.

Wasmtime GitHub notifications bot (Feb 19 2025 at 21:03):

jeffcharles requested cfallin for a review on PR #10247.

Wasmtime GitHub notifications bot (Feb 19 2025 at 21:03):

jeffcharles requested wasmtime-core-reviewers for a review on PR #10247.

Wasmtime GitHub notifications bot (Feb 19 2025 at 21:03):

jeffcharles requested alexcrichton for a review on PR #10247.

Wasmtime GitHub notifications bot (Feb 19 2025 at 22:01):

alexcrichton requested saulecabrera for a review on PR #10247.

Wasmtime GitHub notifications bot (Feb 19 2025 at 23:45):

github-actions[bot] commented on PR #10247:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 20 2025 at 13:13):

saulecabrera submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Feb 20 2025 at 14:52):

jeffcharles updated PR #10247.

Wasmtime GitHub notifications bot (Feb 20 2025 at 14:52):

jeffcharles commented on PR #10247:

Going to see if merging main into this branch helps

Wasmtime GitHub notifications bot (Feb 20 2025 at 14:59):

saulecabrera commented on PR #10247:

I think the CI issues should be resolved once https://github.com/bytecodealliance/wasmtime/pull/10253 lands.

Wasmtime GitHub notifications bot (Feb 20 2025 at 17:12):

jeffcharles updated PR #10247.

Wasmtime GitHub notifications bot (Feb 20 2025 at 20:42):

jeffcharles updated PR #10247.

Wasmtime GitHub notifications bot (Feb 20 2025 at 20:43):

jeffcharles requested saulecabrera for a review on PR #10247.

Wasmtime GitHub notifications bot (Feb 20 2025 at 20:44):

jeffcharles commented on PR #10247:

There was a missing self.ensure_has_avx()? check in v128_neg so the Wast tests would panic instead of returning an error when the AVX extensions weren't available. I've fixed that in the latest commit.

Wasmtime GitHub notifications bot (Feb 20 2025 at 20:51):

saulecabrera has enabled auto merge for PR #10247.

Wasmtime GitHub notifications bot (Feb 20 2025 at 21:18):

saulecabrera merged PR #10247.

Last updated: Feb 28 2025 at 02:27 UTC