Wasmtime GitHub notifications bot (Feb 14 2025 at 21:50): Wasmtime GitHub notifications bot (Feb 14 2025 at 21:50):abrown opened PR #10237 from abrown:assembler-alurmir-again to bytecodealliance:main:
This adds DSL definitions in the assembler _and_ uses the new instructions for ISLE lowering for the following instructions:
addadcorsubsbbxorThe original
AluRmiROpcodevariants are not yet gone; perhaps in a future pass.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 14 2025 at 21:50):abrown requested cfallin for a review on PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 21:50):abrown requested wasmtime-compiler-reviewers for a review on PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 21:51):abrown updated PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:04):cfallin submitted PR review:
Looks good, thanks!
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:04):cfallin created PR review comment:
Should we
assert_eq!(rex.digit, None)here?
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:22):abrown submitted PR review.
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:22):abrown created PR review comment:
Yeah, good point.
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:24):abrown updated PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:48):abrown requested dicej for a review on PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:48):abrown updated PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:48):abrown requested wasmtime-core-reviewers for a review on PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:52):abrown commented on PR #10237:
@cfallin, you might want to take another glance at 9b8aecb; it looks like we're emitting a slightly longer encoding somewhere? Not sure if that's ok...
Wasmtime GitHub notifications bot (Feb 14 2025 at 22:52):abrown requested cfallin for a review on PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 23:52):abrown updated PR #10237.
Wasmtime GitHub notifications bot (Feb 14 2025 at 23:54):abrown commented on PR #10237:
Ok, looking into this more, we had some extra 8-bit lowering rules up in
cranelift-codegenthat I hadn't ported to the new assembler--no new instructions needed, just some extra ISLE rules. This undoes any extra bytes added in prior disassembly tests and should match what we had incranelift-codegenpreviously.
Wasmtime GitHub notifications bot (Feb 14 2025 at 23:57):abrown edited a comment on PR #10237:
Ok, looking into this more, we had some extra 8-bit lowering rules up in
cranelift-codegenthat I hadn't ported to the new assembler--no new instructions needed, just some extra ISLE rules. aec34e1 undoes any extra bytes added in prior disassembly tests and should match what we had incranelift-codegenpreviously.
Wasmtime GitHub notifications bot (Feb 15 2025 at 02:18):cfallin commented on PR #10237:
Updates look good -- thanks for tracking down that divergence!
Wasmtime GitHub notifications bot (Feb 15 2025 at 02:39):cfallin merged PR #10237.
Last updated: Feb 28 2025 at 03:10 UTC