Wasmtime GitHub notifications bot (Feb 14 2025 at 17:07): Wasmtime GitHub notifications bot (Feb 14 2025 at 17:07):alexcrichton opened PR #10233 from alexcrichton:x64-shld to bytecodealliance:main:
This commit is similar to #10229 except that it uses the x64
shldinstruction. This instruction was not previously supported by Cranelift so I opted to add support via the newcranelift-assembler-x64crate instead of trying to fit it into the existingemit.rs/MInstinfrastructure. This was a good learning experience for myself and was also fun to do!<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 14 2025 at 17:07):alexcrichton commented on PR #10233:
I'm opening this as a draft PR because https://github.com/bytecodealliance/wasmtime/pull/10232 should land first and this should rebase on top of that. In talking with Andrew I temporarily came up with the "solution" in this PR but our conclusion was that #10232 was the better way to go in terms of robustly supporting this encoding pattern in x64 instructions.
Wasmtime GitHub notifications bot (Feb 14 2025 at 17:08):alexcrichton commented on PR #10233:
(also cc @abrown)
Wasmtime GitHub notifications bot (Feb 14 2025 at 17:33):alexcrichton updated PR #10233.
Wasmtime GitHub notifications bot (Feb 14 2025 at 18:12):abrown requested abrown for a review on PR #10233.
Wasmtime GitHub notifications bot (Feb 14 2025 at 19:44):github-actions[bot] commented on PR #10233:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:03):alexcrichton updated PR #10233.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:04):alexcrichton has marked PR #10233 as ready for review.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:04):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10233.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:04):alexcrichton requested pchickey for a review on PR #10233.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:04):alexcrichton requested wasmtime-core-reviewers for a review on PR #10233.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:13):abrown submitted PR review:
Makes sense to me!
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:13):abrown created PR review comment:
Huh... let's try this but I'm not sure.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:13):abrown created PR review comment:
Good catch!
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:16):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:16):alexcrichton created PR review comment:
Heh agreed! I figure we'll need to add more heuristics here eventually to figure out how to print and still match att/capstone ordering.
Wasmtime GitHub notifications bot (Feb 14 2025 at 20:48):alexcrichton merged PR #10233.
Last updated: Feb 28 2025 at 02:27 UTC