Wasmtime GitHub notifications bot (Feb 13 2025 at 23:33): Wasmtime GitHub notifications bot (Feb 13 2025 at 23:33):saulecabrera opened PR #10231 from saulecabrera:winch-fuel-on-empty to bytecodealliance:main:
Prior to this commit, fuel consumed was not correctly updated when performing out-of-fuel checks. This is only relevant/noticeable when performing fuel checks on funciton entry, more concretely, when the store contains 1 fuel unit. Any program should immediately trap when the store contains 1 fuel unit, given that all programs should consume at least some fuel, even if empty.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 13 2025 at 23:33):saulecabrera requested cfallin for a review on PR #10231.
Wasmtime GitHub notifications bot (Feb 13 2025 at 23:33):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #10231.
Wasmtime GitHub notifications bot (Feb 13 2025 at 23:33):saulecabrera requested alexcrichton for a review on PR #10231.
Wasmtime GitHub notifications bot (Feb 13 2025 at 23:33):saulecabrera requested wasmtime-core-reviewers for a review on PR #10231.
Wasmtime GitHub notifications bot (Feb 14 2025 at 00:36):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 14 2025 at 00:57):alexcrichton merged PR #10231.
Last updated: Feb 28 2025 at 02:27 UTC