Stream: git-wasmtime

Topic: wasmtime / PR #10228 Winch: Implement avgr instructions f...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2025 at 16:31):

jeffcharles opened PR #10228 from jeffcharles:winch-simd-avgr to bytecodealliance:main:

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #8093. Implements the following instructions:

view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2025 at 16:31):

jeffcharles requested fitzgen for a review on PR #10228.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2025 at 16:31):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10228.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2025 at 16:31):

jeffcharles requested wasmtime-core-reviewers for a review on PR #10228.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 13 2025 at 17:44):

github-actions[bot] commented on PR #10228:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 16:09):

jeffcharles updated PR #10228.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 17:38):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 17:38):

saulecabrera created PR review comment:

Could we avoid this match here entirely and instead delegate the operand size invariant checks to the assembler?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 17:40):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 17:40):

saulecabrera created PR review comment:

It's currently duplicated in both places, and I'm not sure if such duplication is worth it.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 19:35):

jeffcharles updated PR #10228.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 19:36):

jeffcharles requested saulecabrera for a review on PR #10228.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 20:08):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 14 2025 at 20:28):

saulecabrera merged PR #10228.


Last updated: Feb 28 2025 at 03:10 UTC