Stream: git-wasmtime

Topic: wasmtime / PR #10223 Wasm GC: Fix an incorrect assertion ...

Wasmtime GitHub notifications bot (Feb 12 2025 at 17:39):

fitzgen requested alexcrichton for a review on PR #10223.

Wasmtime GitHub notifications bot (Feb 12 2025 at 17:39):

fitzgen requested wasmtime-core-reviewers for a review on PR #10223.

Wasmtime GitHub notifications bot (Feb 12 2025 at 17:39):

fitzgen requested wasmtime-default-reviewers for a review on PR #10223.

Wasmtime GitHub notifications bot (Feb 12 2025 at 17:39):

fitzgen opened PR #10223 from fitzgen:issue-9714-part-2 to bytecodealliance:main:

see commit messages for details

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 13 2025 at 06:01):

alexcrichton commented on PR #10223:

Nick and I talked a bit about this in person and the conclusion was that we'll instead try canonicalizing ModuleTypes when the signature collection is created instead of later when type-checking happens to avoid threading through the new state

Wasmtime GitHub notifications bot (Feb 13 2025 at 22:22):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #10223.

Wasmtime GitHub notifications bot (Feb 13 2025 at 22:22):

fitzgen updated PR #10223.

Wasmtime GitHub notifications bot (Feb 13 2025 at 22:22):

fitzgen requested abrown for a review on PR #10223.

Wasmtime GitHub notifications bot (Feb 13 2025 at 22:31):

fitzgen updated PR #10223.

Wasmtime GitHub notifications bot (Feb 13 2025 at 22:37):

fitzgen updated PR #10223.

Wasmtime GitHub notifications bot (Feb 13 2025 at 23:44):

github-actions[bot] commented on PR #10223:

Subscribe to Label Action

cc @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:ref-types", "winch"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types
• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 14 2025 at 17:03):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 14 2025 at 17:24):

alexcrichton merged PR #10223.

Last updated: Feb 28 2025 at 03:10 UTC