Wasmtime GitHub notifications bot (Feb 12 2025 at 07:49): Wasmtime GitHub notifications bot (Feb 12 2025 at 07:49):fitzgen opened PR #10221 from fitzgen:issue-10171 to bytecodealliance:main:
In the case where we need to check for either null or i31refs, we were attempting to fold the two checks together with a bitwise-and and a bitmask, but that was incorrect and buggy. We need to actually do the two separate checks and bitwise-or them together.
Fixes #10171
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 12 2025 at 07:49):fitzgen requested pchickey for a review on PR #10221.
Wasmtime GitHub notifications bot (Feb 12 2025 at 07:49):fitzgen requested wasmtime-core-reviewers for a review on PR #10221.
Wasmtime GitHub notifications bot (Feb 12 2025 at 07:52):alexcrichton created PR review comment:
Curiosity: why is this typed
u64? This discriminant is technically only for 32-bit values right?
Wasmtime GitHub notifications bot (Feb 12 2025 at 07:52):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 12 2025 at 09:45):github-actions[bot] commented on PR #10221:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 12 2025 at 17:14):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Feb 12 2025 at 17:14):fitzgen created PR review comment:
I think it was useful at some point but might not be useful anymore, I’d have to look at uses again
Wasmtime GitHub notifications bot (Feb 12 2025 at 17:23):fitzgen-f5 submitted PR review.
Wasmtime GitHub notifications bot (Feb 12 2025 at 17:23):fitzgen-f5 created PR review comment:
Looks like there's no issue changing it to a u32, so I'll do that in a follow up
Wasmtime GitHub notifications bot (Feb 12 2025 at 17:35):fitzgen merged PR #10221.
Last updated: Feb 28 2025 at 03:10 UTC