Stream: git-wasmtime

Topic: wasmtime / PR #10203 Winch: Clean up Wast SIMD tests

Wasmtime GitHub notifications bot (Feb 06 2025 at 23:09):

jeffcharles opened PR #10203 from jeffcharles:winch-simd-enable-tests to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Clean up some of the Winch SIMD Wast tests. I had initially set these up as copies of the spec testsuite with some instructions commented out so there would be some spec test coverage of what I was implementing. But now it looks like the actual spec testsuite can be used for most of them so I'm deleting them. The exception is simd_multivalue which doesn't have a corresponding spec test so I've renamed it to remove the leading underscore. For the remaining files, I've uncommented tests that should now pass.

Wasmtime GitHub notifications bot (Feb 06 2025 at 23:09):

jeffcharles requested pchickey for a review on PR #10203.

Wasmtime GitHub notifications bot (Feb 06 2025 at 23:09):

jeffcharles requested wasmtime-core-reviewers for a review on PR #10203.

Wasmtime GitHub notifications bot (Feb 07 2025 at 03:21):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Feb 07 2025 at 03:43):

alexcrichton commented on PR #10203:

It's unfortunately buried, but the failure is here

Wasmtime GitHub notifications bot (Feb 07 2025 at 03:43):

alexcrichton commented on PR #10203:

notably:

---- Winch/pooling/./tests/misc_testsuite/winch/_simd_load.wast ----
failed to run spec test with default engine

Caused by:
    0: failed directive on ./tests/misc_testsuite/winch/_simd_load.wast:20:1
    1: Compilation error: Instruction not implemented for CPUs without AVX support

---- Winch/./tests/misc_testsuite/winch/_simd_load.wast ----
failed to run spec test with default engine

Caused by:
    0: failed directive on ./tests/misc_testsuite/winch/_simd_load.wast:20:1
    1: Compilation error: Instruction not implemented for CPUs without AVX support


failures:
    Winch/pooling/./tests/misc_testsuite/winch/_simd_load.wast
    Winch/./tests/misc_testsuite/winch/_simd_load.wast

Wasmtime GitHub notifications bot (Feb 07 2025 at 15:08):

jeffcharles updated PR #10203.

Wasmtime GitHub notifications bot (Feb 07 2025 at 15:10):

jeffcharles commented on PR #10203:

That makes sense. The tests that were already uncommented probably didn't rely on AVX support, but the tests I uncommented in this PR do rely on it, so the test needs to be added to the unsupported with no AVX list.

Wasmtime GitHub notifications bot (Feb 07 2025 at 15:48):

alexcrichton merged PR #10203.

Last updated: Feb 28 2025 at 02:27 UTC