Stream: git-wasmtime

Topic: wasmtime / PR #10201 winch(aarch64): Correct treatment fo...

Wasmtime GitHub notifications bot (Feb 06 2025 at 18:49):

saulecabrera opened PR #10201 from saulecabrera:winch-store-flags to bytecodealliance:main:

This commit is one more in the series of executing spec tests for aarch64.

It's mostly a small follow-up to https://github.com/bytecodealliance/wasmtime/pull/10146, in which I omitted contextualizing the memory flags for stores as well as ensuring that the SP is aligned when emitting other trapping instructions like checked_uadd.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 06 2025 at 18:49):

saulecabrera requested cfallin for a review on PR #10201.

Wasmtime GitHub notifications bot (Feb 06 2025 at 18:49):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #10201.

Wasmtime GitHub notifications bot (Feb 06 2025 at 20:44):

github-actions[bot] commented on PR #10201:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 21 2025 at 17:31):

cfallin submitted PR review:

Looks good, sorry for the delay!

Wasmtime GitHub notifications bot (Feb 21 2025 at 17:31):

cfallin created PR review comment:

Can we add a comment here noting why the SP alignment is needed? (Is it required to be aligned at all potentially trapping ops?)

Wasmtime GitHub notifications bot (Feb 24 2025 at 14:32):

saulecabrera updated PR #10201.

Wasmtime GitHub notifications bot (Feb 24 2025 at 14:33):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Feb 24 2025 at 14:33):

saulecabrera created PR review comment:

Done, thanks!

Wasmtime GitHub notifications bot (Feb 24 2025 at 14:36):

saulecabrera has enabled auto merge for PR #10201.

Wasmtime GitHub notifications bot (Feb 24 2025 at 15:08):

saulecabrera merged PR #10201.

Last updated: Feb 28 2025 at 03:10 UTC