Stream: git-wasmtime

Topic: wasmtime / PR #10197 support pulley even if host triplet ...

Wasmtime GitHub notifications bot (Feb 05 2025 at 23:31):

cpetig requested fitzgen for a review on PR #10197.

Wasmtime GitHub notifications bot (Feb 05 2025 at 23:31):

cpetig requested wasmtime-core-reviewers for a review on PR #10197.

Wasmtime GitHub notifications bot (Feb 05 2025 at 23:31):

cpetig opened PR #10197 from cpetig:pulley-fix to bytecodealliance:main:

Previously executing pulley required winch or cranelift even if pulley would be available - because the host triplet was used unconditionally if possible.

Wasmtime GitHub notifications bot (Feb 06 2025 at 02:08):

github-actions[bot] commented on PR #10197:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Feb 06 2025 at 06:57):

alexcrichton submitted PR review:

Thanks for this! I think though it might be best to ungate the condition above this for if let Some(target) perhaps? Previously that was only available with cranelift/winch because it was part of self.compiler_config but refactoring lately has made self.target always available regardless of crate features and the cfg's haven't really caught up yet. I think that would remove the need for the addition here too?

Wasmtime GitHub notifications bot (Feb 06 2025 at 06:58):

alexcrichton submitted PR review:

Thanks for this! I think though it might be best to ungate the condition above this for if let Some(target) perhaps? Previously that was only available with cranelift/winch because it was part of self.compiler_config, but refactoring lately has made self.target always available regardless of crate features and the cfg's haven't really caught up yet. I think that would remove the need for the addition here too?

Last updated: Feb 28 2025 at 01:30 UTC