Wasmtime GitHub notifications bot (Feb 05 2025 at 18:39): Wasmtime GitHub notifications bot (Feb 05 2025 at 18:39):fitzgen requested alexcrichton for a review on PR #10192.
Wasmtime GitHub notifications bot (Feb 05 2025 at 18:39):fitzgen opened PR #10192 from fitzgen:clarify-result-when-null-or-i31 to bytecodealliance:main:
When the ref is null or i31, just use an
iconstresult value directly, rather than reusing the result of the check for null or i31. Reusing the result doesn't actually yield better code (equivalently good or worse depending on if null/i31 are allowed or not) and is somewhat subtle -- I have to stop and re-think through its correctness each time I see it again -- so this change should be a welcome improvement.This does not change the logic of the emitted code, but does slightly change the emitted code itself.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 05 2025 at 18:39):fitzgen requested wasmtime-core-reviewers for a review on PR #10192.
Wasmtime GitHub notifications bot (Feb 05 2025 at 19:44):github-actions[bot] commented on PR #10192:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 06 2025 at 06:59):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Feb 06 2025 at 07:20):alexcrichton merged PR #10192.
Last updated: Apr 17 2025 at 18:04 UTC