Wasmtime GitHub notifications bot (Feb 05 2025 at 18:31): Wasmtime GitHub notifications bot (Feb 05 2025 at 18:31):fitzgen opened PR #10191 from fitzgen:lots-of-gc-related-trace-logs to bytecodealliance:main:
This is some general trace logging to help with debugging issues like https://github.com/bytecodealliance/wasmtime/issues/10171.
This adds trace logging for:
InstructionBuildermethods- Switching
FunctionBuilders between blocks- A ton of GC-related Wasm-to-CLIF translation bits
The result is that it is wayyyyyyyy easier to tell what CLIF is generated for what purpose when staring at trace logs, particularly for Wasm GC things where a single Wasm instruction might become many blocks of CLIF.
At the same time, this consolidates some
translate_{array,struct}_get{,_s,_u}helpers so that there is less code duplication (purely mechanical; should not change any actual translations or instructions we emit) just so that there were fewer places to add trace logs to.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Feb 05 2025 at 18:31):fitzgen requested abrown for a review on PR #10191.
Wasmtime GitHub notifications bot (Feb 05 2025 at 18:31):fitzgen requested wasmtime-compiler-reviewers for a review on PR #10191.
Wasmtime GitHub notifications bot (Feb 05 2025 at 18:31):fitzgen requested dicej for a review on PR #10191.
Wasmtime GitHub notifications bot (Feb 05 2025 at 18:31):fitzgen requested wasmtime-core-reviewers for a review on PR #10191.
Wasmtime GitHub notifications bot (Feb 05 2025 at 18:43):fitzgen updated PR #10191.
Wasmtime GitHub notifications bot (Feb 05 2025 at 19:44):github-actions[bot] commented on PR #10191:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 05 2025 at 22:01):abrown submitted PR review:
Makes sense to me!
Wasmtime GitHub notifications bot (Feb 05 2025 at 22:22):abrown merged PR #10191.
Last updated: Feb 28 2025 at 02:27 UTC