Stream: git-wasmtime

Topic: wasmtime / PR #10178 asm: prepare docs for publishing

Wasmtime GitHub notifications bot (Feb 04 2025 at 03:46):

abrown requested fitzgen for a review on PR #10178.

Wasmtime GitHub notifications bot (Feb 04 2025 at 03:46):

abrown requested wasmtime-compiler-reviewers for a review on PR #10178.

Wasmtime GitHub notifications bot (Feb 04 2025 at 03:46):

abrown opened PR #10178 from abrown:assembler-docs to bytecodealliance:main:

This change is motivated by staring at the output of cargo doc for the cranelift-assembler-x64 crate. In order to write a sensible top-level example, I felt it was best to refactor how we construct the instructions: this removes the build module and adds conventional <inst_name>::new functions to each instruction. Also, a generated From implementation makes it easier to convert to an Inst.

This change has other doc-related refactorings and tweaks, but should not change any functionality.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Feb 04 2025 at 17:40):

fitzgen submitted PR review:

nice, thanks!

Wasmtime GitHub notifications bot (Feb 04 2025 at 18:02):

fitzgen merged PR #10178.

Last updated: Feb 28 2025 at 02:27 UTC