Stream: git-wasmtime

Topic: wasmtime / PR #10170 Winch: implement `v128` `neg` and sh...

Wasmtime GitHub notifications bot (Feb 03 2025 at 10:21):

MarinPostma opened PR #10170 from MarinPostma:packed-integer-arithmetic-pt2 to bytecodealliance:main:

implements the following instructions for winch x64 backend:

• i8x16.neg
• i16x8.neg
• i32x4.neg
• i64x2.neg
• i8x16.shl
• i16x8.shl
• i32x4.shl
• i64x2.shl
• i8x16.shr_s
• i16x8.shr_s
• i32x4.shr_s
• i64x2.shr_s
• i8x16.shr_u
• i16x8.shr_u
• i32x4.shr_u
• i64x2.shr_u

depends on #10147

#8093

Wasmtime GitHub notifications bot (Feb 03 2025 at 10:21):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #10170.

Wasmtime GitHub notifications bot (Feb 03 2025 at 10:21):

MarinPostma requested cfallin for a review on PR #10170.

Wasmtime GitHub notifications bot (Feb 03 2025 at 10:21):

MarinPostma requested wasmtime-core-reviewers for a review on PR #10170.

Wasmtime GitHub notifications bot (Feb 03 2025 at 10:21):

MarinPostma requested pchickey for a review on PR #10170.

Wasmtime GitHub notifications bot (Feb 03 2025 at 10:21):

MarinPostma requested wasmtime-default-reviewers for a review on PR #10170.

Wasmtime GitHub notifications bot (Feb 03 2025 at 10:27):

MarinPostma edited PR #10170:

implements the following instructions for winch x64 backend:

• i8x16.neg
• i16x8.neg
• i32x4.neg
• i64x2.neg
• i8x16.shl
• i16x8.shl
• i32x4.shl
• i64x2.shl
• i8x16.shr_s
• i16x8.shr_s
• i32x4.shr_s
• i64x2.shr_s
• i8x16.shr_u
• i16x8.shr_u
• i32x4.shr_u
• i64x2.shr_u

depends on #10147

One thing that we may improve is the handling of constants: My initial implementation introduced WellKnown addresses, because this is how cranelift implemented shifts. I revised that later on, to keep things simple, and used the constant infrastructure already present in winch. The use of well known constant addresses _may_ be more efficient, if we decided to use them. Happy to do that in a followup.

#8093

Wasmtime GitHub notifications bot (Feb 03 2025 at 14:05):

MarinPostma updated PR #10170.

Wasmtime GitHub notifications bot (Feb 03 2025 at 14:15):

MarinPostma edited PR #10170:

implements the following instructions for winch x64 backend:

• i8x16.neg
• i16x8.neg
• i32x4.neg
• i64x2.neg
• i8x16.shl
• i16x8.shl
• i32x4.shl
• i64x2.shl
• i8x16.shr_s
• i16x8.shr_s
• i32x4.shr_s
• i64x2.shr_s
• i8x16.shr_u
• i16x8.shr_u
• i32x4.shr_u
• i64x2.shr_u

One thing that we may improve is the handling of constants: My initial implementation introduced WellKnown addresses, because this is how cranelift implemented shifts. I revised that later on, to keep things simple, and used the constant infrastructure already present in winch. The use of well known constant addresses _may_ be more efficient, if we decided to use them. Happy to do that in a followup.

#8093

Wasmtime GitHub notifications bot (Feb 03 2025 at 15:44):

github-actions[bot] commented on PR #10170:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:docs", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Feb 03 2025 at 16:32):

cfallin requested saulecabrera for a review on PR #10170.

Wasmtime GitHub notifications bot (Feb 03 2025 at 16:33):

cfallin commented on PR #10170:

Passing the review baton again to Saúl -- thanks!

Wasmtime GitHub notifications bot (Feb 03 2025 at 17:24):

MarinPostma has marked PR #10170 as ready for review.

Wasmtime GitHub notifications bot (Feb 06 2025 at 13:46):

saulecabrera submitted PR review:

Looks reasonable to me, thanks!

Wasmtime GitHub notifications bot (Feb 06 2025 at 14:04):

saulecabrera commented on PR #10170:

The failure is because in main xmm_rmi_rvex no longer exists.

Wasmtime GitHub notifications bot (Feb 06 2025 at 15:38):

MarinPostma commented on PR #10170:

@saulecabrera rebased

Wasmtime GitHub notifications bot (Feb 06 2025 at 15:46):

MarinPostma updated PR #10170.

Wasmtime GitHub notifications bot (Feb 06 2025 at 18:00):

saulecabrera merged PR #10170.

Last updated: Feb 28 2025 at 01:30 UTC