Stream: git-wasmtime

Topic: wasmtime / PR #10149 Enable warnings if `gc` is disabled

Wasmtime GitHub notifications bot (Jan 29 2025 at 19:45):

alexcrichton opened PR #10149 from alexcrichton:no-warnings-gc to bytecodealliance:main:

Continuation of work in #10131. This additionally handles turning off gc-null and gc-drc and the various combinations within.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 29 2025 at 19:45):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10149.

Wasmtime GitHub notifications bot (Jan 29 2025 at 19:45):

alexcrichton requested dicej for a review on PR #10149.

Wasmtime GitHub notifications bot (Jan 29 2025 at 20:25):

alexcrichton updated PR #10149.

Wasmtime GitHub notifications bot (Jan 29 2025 at 21:44):

github-actions[bot] commented on PR #10149:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 29 2025 at 22:44):

github-actions[bot] commented on PR #10149:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Jan 30 2025 at 00:17):

alexcrichton updated PR #10149.

Wasmtime GitHub notifications bot (Jan 30 2025 at 16:14):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2025 at 16:14):

abrown created PR review comment:

I guess there are multiple uses in this module or something like that?

Wasmtime GitHub notifications bot (Jan 30 2025 at 16:14):

abrown created PR review comment:

I thought you wanted to fully qualify these at the use site?

Wasmtime GitHub notifications bot (Jan 30 2025 at 16:34):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2025 at 16:34):

alexcrichton created PR review comment:

Ideally yeah I generally prefer avoiding #[cfg] on imports since it feels pretty noisy, but this one was used so much it was getting even noisier to have fully qualified use-sites.

Probably an indicator to create crates/wasmtime/src/runtime/store/gc.rs perhaps...

Wasmtime GitHub notifications bot (Jan 30 2025 at 17:15):

alexcrichton merged PR #10149.

Last updated: Feb 28 2025 at 03:10 UTC