Stream: git-wasmtime

Topic: wasmtime / PR #10147 Winch: packed integer basic arithmet...

Wasmtime GitHub notifications bot (Jan 29 2025 at 13:03):

MarinPostma opened PR #10147 from MarinPostma:packed-integer-arithmetic to bytecodealliance:main:

implements the following instructions for winch x64:

• i8x16.add
• i8x16.add_sat_u
• i8x16.add_sat_s
• i16x8.add
• i16x8.add_sat_u
• i16x8.add_sat_s
• i32x4.add
• i64x2.add
• i8x16.sub
• i8x16.sub_sat_u
• i8x16.sub_sat_s
• i16x8.sub
• i16x8.sub_sat_u
• i16x8.sub_sat_s
• i32x4.sub
• i64x2.sub
• i8x16.mul
• i16x8.mul
• i32x4.mul
• i64x2.mul

#8093

Wasmtime GitHub notifications bot (Jan 29 2025 at 13:03):

MarinPostma requested fitzgen for a review on PR #10147.

Wasmtime GitHub notifications bot (Jan 29 2025 at 13:03):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #10147.

Wasmtime GitHub notifications bot (Jan 29 2025 at 13:03):

MarinPostma requested wasmtime-core-reviewers for a review on PR #10147.

Wasmtime GitHub notifications bot (Jan 29 2025 at 13:06):

MarinPostma edited PR #10147:

implements the following instructions for winch x64:

• i8x16.add
• i8x16.add_sat_u
• i8x16.add_sat_s
• i16x8.add
• i16x8.add_sat_u
• i16x8.add_sat_s
• i32x4.add
• i64x2.add
• i8x16.sub
• i8x16.sub_sat_u
• i8x16.sub_sat_s
• i16x8.sub
• i16x8.sub_sat_u
• i16x8.sub_sat_s
• i32x4.sub
• i64x2.sub
• i16x8.mul
• i32x4.mul
• i64x2.mul

#8093

Wasmtime GitHub notifications bot (Jan 29 2025 at 13:10):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 29 2025 at 17:11):

MarinPostma submitted PR review.

Wasmtime GitHub notifications bot (Jan 29 2025 at 17:11):

MarinPostma created PR review comment:

naming-wise, I'm completely sure what to call those. Maybe vector_add is more appropriate?

Wasmtime GitHub notifications bot (Jan 29 2025 at 17:19):

saulecabrera commented on PR #10147:

I can take this review.

Wasmtime GitHub notifications bot (Jan 29 2025 at 17:19):

saulecabrera requested saulecabrera for a review on PR #10147.

Wasmtime GitHub notifications bot (Jan 29 2025 at 21:15):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 30 2025 at 11:53):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 30 2025 at 15:15):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 30 2025 at 15:15):

saulecabrera created PR review comment:

I don't think we should make this a hard requirement, given that our baseline is AVX.

Given that Intel suggests that there's no penalty on mixing AVX with AVX512 instructions , we could emit AVX512 if they are available, however in case they aren't we still need to emit a fallback to avoid bumping our baseline for this operation. For reference: https://github.com/bytecodealliance/wasmtime/blob/main/cranelift/codegen/src/isa/x64/lower.isle#L1121

Wasmtime GitHub notifications bot (Jan 30 2025 at 15:15):

saulecabrera created PR review comment:

I think the naming is fine here, as far as I can tell, we don't have any other vector naming convention.

Wasmtime GitHub notifications bot (Jan 31 2025 at 16:54):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 31 2025 at 16:59):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:00):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:00):

MarinPostma submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:00):

MarinPostma created PR review comment:

my bad, I misunderstood your DM about what we expected to support. I have ported cranelift fallback implementation.

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:05):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:07):

MarinPostma submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:07):

MarinPostma created PR review comment:

hold on I just foudn a bug

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:58):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 31 2025 at 17:58):

MarinPostma edited PR review comment.

Wasmtime GitHub notifications bot (Jan 31 2025 at 18:01):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 31 2025 at 20:29):

MarinPostma submitted PR review.

Wasmtime GitHub notifications bot (Jan 31 2025 at 20:29):

MarinPostma created PR review comment:

Fixed

Wasmtime GitHub notifications bot (Jan 31 2025 at 22:34):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Jan 31 2025 at 22:39):

MarinPostma updated PR #10147.

Wasmtime GitHub notifications bot (Feb 03 2025 at 12:51):

saulecabrera submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Feb 03 2025 at 13:12):

saulecabrera merged PR #10147.

Last updated: Feb 28 2025 at 03:10 UTC