Stream: git-wasmtime

Topic: wasmtime / PR #10145 Enable warnings if `async` is disabled

Wasmtime GitHub notifications bot (Jan 28 2025 at 23:20):

alexcrichton opened PR #10145 from alexcrichton:no-warnings-async to bytecodealliance:main:

Continuation of work in #10131.

This required a number of organizational changes to help cut down on #[cfg], notably lots of async-related pieces from store.rs have moved to store/async_.rs to avoid having lots of conditional imports. Additionally this removes all of the #[cfg] annotations on those methods already.

Additionally the signature of AsyncCx::block_on was updated to be a bit more general to ideally remove the need for Pin but it ended up not panning out quite just yet. In the future it should be possible to remove the need for Pin at callsites though.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 28 2025 at 23:20):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10145.

Wasmtime GitHub notifications bot (Jan 28 2025 at 23:20):

alexcrichton requested pchickey for a review on PR #10145.

Wasmtime GitHub notifications bot (Jan 29 2025 at 17:51):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jan 29 2025 at 18:30):

alexcrichton requested dicej for a review on PR #10145.

Wasmtime GitHub notifications bot (Jan 29 2025 at 18:30):

alexcrichton updated PR #10145.

Wasmtime GitHub notifications bot (Jan 29 2025 at 18:30):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10145.

Wasmtime GitHub notifications bot (Jan 29 2025 at 18:31):

alexcrichton has enabled auto merge for PR #10145.

Wasmtime GitHub notifications bot (Jan 29 2025 at 19:07):

alexcrichton merged PR #10145.

Last updated: Feb 28 2025 at 01:30 UTC