Stream: git-wasmtime

Topic: wasmtime / PR #10132 Update cli book docs for toml cli op...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 01:44):

ludfjig opened PR #10132 from ludfjig:toml_docs to bytecodealliance:main:

Updates the doc for flag introduced in #9811.

Feedback appreciated, happy to change things around. The reason I added some stuff on the --optimize, --debug things were to be able to reference those options in the TOML section.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 01:44):

ludfjig requested alexcrichton for a review on PR #10132.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 01:44):

ludfjig requested wasmtime-default-reviewers for a review on PR #10132.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 01:48):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 01:48):

alexcrichton created PR review comment:

For this, could we actually use #[serde(rename_all = "...")] to blanket rename everything to kebab-case? That way it'd be the same on the CLI and in TOML?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 04:46):

ludfjig updated PR #10132.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 04:46):

ludfjig requested alexcrichton for a review on PR #10132.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 28 2025 at 04:46):

ludfjig requested wasmtime-core-reviewers for a review on PR #10132.

Last updated: Feb 28 2025 at 01:30 UTC