Stream: git-wasmtime

Topic: wasmtime / PR #10131 Start work towards always-warnings i...

Wasmtime GitHub notifications bot (Jan 28 2025 at 01:27):

alexcrichton opened PR #10131 from alexcrichton:towards-warnings-always to bytecodealliance:main:

This PR is an attempt to make progress after https://github.com/bytecodealliance/wasmtime/pull/10108. The goal of this PR is to create a list of features to burn down over time and to have dead_code and unused_imports lints on-by-default in Wasmtime. The feature = "default" gate on this allow directive was replaced with individual features. The hope is that as individual features are removed from this list we can fix the resulting warnings and the commit such a ratchet.

The first commit here replaces not(feature = "default") with not(any(...)) for all features in the default feature. A few features are removed until one was found to trigger a warning. The warning was then fixed generating this PR.

My hope is that if others feel this is a good approach to take that we'd land this and then over time continue to ratchet down this list and remove more warnings. I don't think this is a perfect strategy because we don't test all feature combinations in CI, but it's hopefully at least progress.

Wasmtime GitHub notifications bot (Jan 28 2025 at 01:27):

alexcrichton requested fitzgen for a review on PR #10131.

Wasmtime GitHub notifications bot (Jan 28 2025 at 01:27):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10131.

Wasmtime GitHub notifications bot (Jan 28 2025 at 01:30):

alexcrichton updated PR #10131.

Wasmtime GitHub notifications bot (Jan 28 2025 at 01:47):

alexcrichton updated PR #10131.

Wasmtime GitHub notifications bot (Jan 28 2025 at 01:47):

alexcrichton edited PR #10131:

This PR is an attempt to make progress after https://github.com/bytecodealliance/wasmtime/pull/10108. The goal of this PR is to create a list of features to burn down over time and to have dead_code and unused_imports lints on-by-default in Wasmtime. The feature = "default" gate on this allow directive was replaced with individual features. The hope is that as individual features are removed from this list we can fix the resulting warnings and the commit such a ratchet.

The first commit here replaces not(feature = "default") with any(not(...)) for all features in the default feature. A few features are removed until one was found to trigger a warning. The warning was then fixed generating this PR.

My hope is that if others feel this is a good approach to take that we'd land this and then over time continue to ratchet down this list and remove more warnings. I don't think this is a perfect strategy because we don't test all feature combinations in CI, but it's hopefully at least progress.

Wasmtime GitHub notifications bot (Jan 28 2025 at 02:10):

alexcrichton updated PR #10131.

Wasmtime GitHub notifications bot (Jan 28 2025 at 02:36):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Jan 28 2025 at 15:44):

alexcrichton merged PR #10131.

Last updated: Feb 28 2025 at 03:10 UTC