Stream: git-wasmtime

Topic: wasmtime / PR #1013 Modernize implementation of interface...

Wasmtime GitHub notifications bot (Jun 25 2020 at 18:46):

alexcrichton edited PR #1013 from wasm-interface-types-update to main:

This commit is the start of the modernization of the implementation of
interface types in wasmtime. This has a long way to go, and like the
previous iteration, chunks of it are already destined to get thrown
away.

The current state of affairs is that the implementation of interface
types in wasmtime feels very "bolted on" because, well, it was! The
wasmtime-interface-types crate is not well integrated with the
wasmtime API crate. Additionally it implements an older version of the
interface types proposal dating back to when it was still based on
WebIDL bindings. The goals of this PR are to integrate interface types
into the wasmtime API crate as well as update the implementation to
the current proposal, which is more instruction/adapter based.

Support here is built on top of the tools in the [wasm-interface-types]
repository which contain various pieces of functionality like parsing
the text format, parsing the binary format, stringifying the binary
format, and validating the binary format. These tools are intended to be
developed standalone from Wasmtime itself to encourage other users (like
wasm-bindgen, a generator for interface types).

This should also fix a number of integration issues around the interface
types demos we have (eventually) since wasm-bindgen is targeting the
wasm-interface-types family of crates rather than the older WebIDL
bindings proposals.

The current status of this commit/PR is that it is a step in the right
direction but incomplete. I started this work a few months ago when I
had some more time and have been occasionally rebasing it on the current
wasmtime master branch. Only a few simple instructions are supported
(and it's all via an interpreter, nothing compiled), and "hard" things
like strings have yet to be done.

What is implemented, however, falls into categories like:

• API integration into the wasmtime crate is sorted out

  • The ValType type is enhanced with interface types.
  • The Val type is enhanced with interface types values.
  • The Config type has a gate for the interface types proposal like
    it does all other proposals.

• The wasmtime-interface-types crate is deleted and all users are
  migrated to the wasmtime crate exclusively.

• The test harness has been enhanced with an invented *.wast syntax to
  cover interface types. I basically add things like s8.const foo as
  well as updated the parser to be able to parse @interface
  directives. Again this is sort of an invented format, but the
  intention is that we can easily write *.wast tests the same way for
  interface types how we do for the core spec.

I don't think we want to land this as-is because of how little of
interface types it implements. Additionally there's parallel work that's
been happening in Cranelift to jit interface types stubs which we may
wish to sync up with as well. In any case the main purpose of this
commit is to add fuel to the interface types discussion and hopefully
give us something concrete to work with as well.

[wasm-interface-types]: https://github.com/bytecodealliance/wasm-interface-types

Wasmtime GitHub notifications bot (Aug 05 2020 at 15:02):

alexcrichton closed without merge PR #1013.

Last updated: Nov 22 2024 at 16:03 UTC