Stream: git-wasmtime

Topic: wasmtime / PR #10112 pulley: Expand provenance test some ...

Wasmtime GitHub notifications bot (Jan 25 2025 at 01:53):

alexcrichton opened PR #10112 from alexcrichton:more-provenance-test-things to bytecodealliance:main:

Cover more styles of function calls and a trap or two. This required fixing some issues with libcalls, notably ensuring that expose_provenance() is called at some point on the function pointers and additionally ensuring that the signedness of integer arguments were the same. The internal macro previously used i32 and i64 but that was actually used everywhere on the host as u32 and u64. There was some confusion in some signatures so this commit fixes things to force everyone to use unsigned integers everywhere to match type we ascribe, the type it's defined with, and how it's called with Pulley.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 25 2025 at 01:53):

alexcrichton requested fitzgen for a review on PR #10112.

Wasmtime GitHub notifications bot (Jan 25 2025 at 01:53):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10112.

Wasmtime GitHub notifications bot (Jan 25 2025 at 01:53):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10112.

Wasmtime GitHub notifications bot (Jan 25 2025 at 01:53):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10112.

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:51):

github-actions[bot] commented on PR #10112:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "wasmtime:api", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 27 2025 at 17:07):

fitzgen submitted PR review:

Nice

Wasmtime GitHub notifications bot (Jan 27 2025 at 17:33):

fitzgen merged PR #10112.

Last updated: Feb 28 2025 at 01:30 UTC