Stream: git-wasmtime

Topic: wasmtime / PR #10105 wasmtime-wit-bindgen: use core inste...

Wasmtime GitHub notifications bot (Jan 24 2025 at 19:53):

pchickey opened PR #10105 from bytecodealliance:pch/wasmtime_bindgen_nostd to bytecodealliance:main:

prtest:full

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:36):

pchickey updated PR #10105.

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:40):

pchickey edited PR #10105:

Improve compatibility with #![no_std] builds by substituting all uses of std:: for core:: in wasmtime-wit-bindgen output.

The one use of the std cargo feature in this crate was to gate emitting impl std::error::Error for ..., now that Error is in core we can unconditionally emit an impl core::error::Error for ..., and get rid of that cargo feature.

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:42):

pchickey edited PR #10105:

Improve compatibility with #![no_std] builds by substituting all uses of std:: for core:: in wasmtime-wit-bindgen output.

The one use of the std cargo feature in this crate was to gate emitting impl std::error::Error for ..., now that Error is in core we can unconditionally emit an impl core::error::Error for ..., and eliminate the std cargo feature in the wasmtime-wit-bindgen and wasmtime-component-macro crates.

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:43):

pchickey updated PR #10105.

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:43):

pchickey has marked PR #10105 as ready for review.

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:43):

pchickey requested dicej for a review on PR #10105.

Wasmtime GitHub notifications bot (Jan 25 2025 at 02:43):

pchickey requested wasmtime-core-reviewers for a review on PR #10105.

Wasmtime GitHub notifications bot (Jan 27 2025 at 15:44):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 27 2025 at 16:05):

alexcrichton merged PR #10105.

Last updated: Feb 28 2025 at 02:27 UTC