alexcrichton requested fitzgen for a review on PR #10098.
alexcrichton opened PR #10098 from alexcrichton:more-pulley-in-miri
to bytecodealliance:main
:
This commit executes a few more functions in Pulley which uncovered a bug where the pulley stack was not properly aligned on the host. This commit refactors things to ensure that the stack is 16-byte aligned on the host. While here the stack is additionally updated to be allocated as uninitialized to avoid paying the initialization cost on each Pulley interpreter being created.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-default-reviewers for a review on PR #10098.
alexcrichton requested wasmtime-core-reviewers for a review on PR #10098.
alexcrichton updated PR #10098.
github-actions[bot] commented on PR #10098:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "pulley", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen submitted PR review:
:+1:
fitzgen merged PR #10098.
Last updated: Apr 17 2025 at 10:03 UTC