Stream: git-wasmtime

Topic: wasmtime / PR #10091 Wasmtime: fix `PartialEq` implementa...

Wasmtime GitHub notifications bot (Jan 23 2025 at 13:33):

fitzgen opened PR #10091 from fitzgen:issue-9714 to bytecodealliance:main:

We were incorrectly checking whether they were in the same rec group (i.e. whether the two RegisteredTypes had the same RecGroupEntry) rather than whether they were actually the same type or not, even if they were in the same rec group.

This fixes one of two issues reported in #9714

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 23 2025 at 13:33):

fitzgen requested alexcrichton for a review on PR #10091.

Wasmtime GitHub notifications bot (Jan 23 2025 at 13:33):

fitzgen requested wasmtime-core-reviewers for a review on PR #10091.

Wasmtime GitHub notifications bot (Jan 23 2025 at 15:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 23 2025 at 15:45):

alexcrichton merged PR #10091.

Last updated: Jan 24 2025 at 00:11 UTC