Stream: git-wasmtime

Topic: wasmtime / PR #10064 Fix a missing increment in p1-to-p2 ...

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:39):

alexcrichton opened PR #10064 from alexcrichton:fix-preopen-path- to bytecodealliance:main:

This commit fixes a bug in the WASIp1-to-WASIp2 adapter during fd_prestat_dir_name where an iterator variable was forgotten to be incremented. That means that getting the path for anything other than the first preopen didn't work correctly.

Closes #10058

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:39):

alexcrichton requested dicej for a review on PR #10064.

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:39):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10064.

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:39):

alexcrichton requested wasmtime-default-reviewers for a review on PR #10064.

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:41):

alexcrichton commented on PR #10064:

On merging I'm going to backport this to a 29.0.1 release and then use that release to propagate the update of the adapter binary into various bits and pieces of tooling (e.g. wasm-component-ld, rustc, wasi-sdk, cargo-component, etc.)

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:46):

rvolosatovs submitted PR review.

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:49):

dicej submitted PR review.

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:52):

alexcrichton has enabled auto merge for PR #10064.

Wasmtime GitHub notifications bot (Jan 21 2025 at 17:56):

pchickey submitted PR review:

C programming, even with Rust syntax, strikes again. Thanks for fixing so quickly. Agree we should patch release where we can.

Wasmtime GitHub notifications bot (Jan 21 2025 at 18:30):

alexcrichton merged PR #10064.

Last updated: Jan 24 2025 at 00:11 UTC