Stream: git-wasmtime

Topic: wasmtime / PR #10060 Winch: fix atomic and/or/xor bug

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 12:55):

MarinPostma requested abrown for a review on PR #10060.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 12:55):

MarinPostma opened PR #10060 from MarinPostma:fix-winch-atomic-and to bytecodealliance:main:

This PR fixes atomic and/or/xor. The issue was that I was using the operand as a destination for the AtomicRmwSeq, but it is a macro-instruction, and the operand ended up being overwritten. This was caught when I enabled the atomic.wast spec tests in https://github.com/bytecodealliance/wasmtime/pull/10039#issuecomment-2603318507.

Investigating into the issue I realized that AtomicRmwSeq also had requirement for one of it's registers, but that didn't show up initially, because I got lucky, and the value was popped in the right register every time I tested.

The fix is to pop-push the operand to compute the address, and then pass the codegen context to masm to allocate the registers.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 12:55):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #10060.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 12:55):

MarinPostma requested wasmtime-core-reviewers for a review on PR #10060.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 12:55):

MarinPostma requested fitzgen for a review on PR #10060.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 14:44):

github-actions[bot] commented on PR #10060:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 17:53):

MarinPostma updated PR #10060.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 19:06):

fitzgen submitted PR review:

LGTM, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 19:26):

fitzgen merged PR #10060.

Last updated: Jan 24 2025 at 00:11 UTC