Stream: git-wasmtime

Topic: wasmtime / PR #10057 Add Pulley support to wasmtime_test ...

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 04:55):

irrio opened PR #10057 from irrio:wasmtime-test-macro-pulley to bytecodealliance:main:

This PR updates the #[wasmtime_test] macro to add support for Pulley.

This was one of the last remaining items in the Pulley TODO List #9747, I figured I'd try to knock it out.

I've renamed the Cranelift compilation strategy to CraneliftNative in order to disambiguate it from CraneliftPulley and to directly match the symbol in the Compiler enum.

CraneliftPulley is now included by default in the compilation strategies used by #[wasmtime_test].

In order to support the tests that are targeting Winch specifically, I've added an only(...) specifier. So instead of #[wasmtime_test(strategies(not(Cranelift)))] it would be #[wasmtime_test(strategies(only(Winch)))].

Now that the wrap_and_typed_i31ref test was running multiple times with different strategies, the static HITS counter was leaking state into the other test and causing things to fail. I moved the counter into the Store to get rid of the static variable.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 04:55):

irrio requested wasmtime-core-reviewers for a review on PR #10057.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 04:55):

irrio requested alexcrichton for a review on PR #10057.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 18:01):

alexcrichton submitted PR review:

Thanks for this!

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 18:24):

alexcrichton merged PR #10057.

Last updated: Jan 24 2025 at 00:11 UTC