pchickey opened PR #10054 from bytecodealliance:pch/invoke_wave
to bytecodealliance:main
:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
pchickey updated PR #10054.
pchickey updated PR #10054.
tpmccallum commented on PR #10054:
Tried this locally and got the following:
cd /Users/tpmccallum git clone https://github.com/bytecodealliance/wasmtime.git cd wasmtime git checkout main git pull origin main git checkout pch/invoke_wave git merge main cargo clean cargo build --release
Repo I used for testing is at https://github.com/tpmccallum/testing_components/tree/main (specifically the
compress
component):tpmccallum@192-168-1-17 compress % /Users/tpmccallum/wasmtime/target/release/wasmtime run --invoke compress target/wasm32-wasip1/debug/compress.wasm Error: failed to run main module `target/wasm32-wasip1/debug/compress.wasm` Caused by: 0: parsing invoke "compress" 1: unexpected end of input at 8..8
pchickey commented on PR #10054:
The wave syntax requires functions to be invoked with parens, so
--invoke "compress()"
should hopefully work. one of the big things missing is better error messages...
tpmccallum commented on PR #10054:
Thanks for the response @pchickey
That makes sense. Thank you, and I will try that next and report back here.
Last updated: Feb 28 2025 at 03:10 UTC