Stream: git-wasmtime

Topic: wasmtime / PR #10040 Move `*mut dyn VMStore` out of `VMCo...


view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2025 at 19:42):

alexcrichton requested fitzgen for a review on PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2025 at 19:42):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2025 at 19:42):

alexcrichton opened PR #10040 from alexcrichton:move-out-of-vmcontext to bytecodealliance:main:

There's no need for this type to be accessible from compiled code, so store and manage it entirely from Rust instead.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2025 at 19:55):

alexcrichton updated PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 17 2025 at 22:36):

alexcrichton updated PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 18:42):

fitzgen submitted PR review:

Nice

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 19:51):

alexcrichton updated PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 19:51):

alexcrichton has enabled auto merge for PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 21 2025 at 21:20):

alexcrichton commented on PR #10040:

I believe the crashes in CI are due to https://github.com/bytecodealliance/wasmtime/pull/10069, so I'm going to re-queue this once that merges (didn't want to mix that up in over here)

view this post on Zulip Wasmtime GitHub notifications bot (Jan 23 2025 at 15:44):

alexcrichton updated PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 23 2025 at 15:44):

alexcrichton has enabled auto merge for PR #10040.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 23 2025 at 16:20):

alexcrichton merged PR #10040.


Last updated: Jan 24 2025 at 00:11 UTC