Stream: git-wasmtime

Topic: wasmtime / PR #10037 Winch: avoid emitting 32->64 extend ...

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:19):

MarinPostma requested abrown for a review on PR #10037.

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:19):

MarinPostma opened PR #10037 from MarinPostma:fix-useless-extend-rmw-winch to bytecodealliance:main:

I got confused by this comment, and read the code too fast, but we actually emit an unnecessary mov when extending from 32 to 64bits on x64 in winch.

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:19):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #10037.

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:21):

MarinPostma requested pchickey for a review on PR #10037.

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:21):

MarinPostma requested wasmtime-core-reviewers for a review on PR #10037.

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:21):

MarinPostma updated PR #10037.

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:34):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 16 2025 at 21:34):

saulecabrera created PR review comment:

from_bits and to_bits already exist in ExtendKind, I believe that should do it here instead of introducing new methods?

Wasmtime GitHub notifications bot (Jan 16 2025 at 22:15):

MarinPostma submitted PR review.

Wasmtime GitHub notifications bot (Jan 16 2025 at 22:15):

MarinPostma created PR review comment:

sure

Wasmtime GitHub notifications bot (Jan 16 2025 at 22:18):

MarinPostma updated PR #10037.

Wasmtime GitHub notifications bot (Jan 16 2025 at 22:26):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 16 2025 at 22:26):

saulecabrera has enabled auto merge for PR #10037.

Wasmtime GitHub notifications bot (Jan 16 2025 at 22:53):

saulecabrera merged PR #10037.

Last updated: Jan 24 2025 at 00:11 UTC