Stream: git-wasmtime

Topic: wasmtime / PR #10032 Winch: Refactor unop to remove size ...

Wasmtime GitHub notifications bot (Jan 16 2025 at 15:05):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #10032.

Wasmtime GitHub notifications bot (Jan 16 2025 at 15:05):

jeffcharles opened PR #10032 from jeffcharles:winch-refactor-unop to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
The only use of the size parameter in unop is to pass it through to the closure argument. However, in many cases the closure doesn't use or can't use the size parameter so it's superfluous in those cases. In the cases where the size parameter is used in the closure, the OperandSize can be trivially inlined. This refactoring simplifies uses of unop in cases where the size parameter is not used.

Wasmtime GitHub notifications bot (Jan 16 2025 at 15:05):

jeffcharles requested fitzgen for a review on PR #10032.

Wasmtime GitHub notifications bot (Jan 16 2025 at 15:14):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 16 2025 at 15:14):

saulecabrera has enabled auto merge for PR #10032.

Wasmtime GitHub notifications bot (Jan 16 2025 at 15:45):

saulecabrera merged PR #10032.

Last updated: Jan 24 2025 at 00:11 UTC