Wasmtime GitHub notifications bot (Jan 15 2025 at 01:45): Wasmtime GitHub notifications bot (Jan 15 2025 at 01:45):alexcrichton opened PR #10021 from alexcrichton:pulley-fix-return-call-indirect to bytecodealliance:main:
This commit fixes an issue in the Pulley backend for the
return_call_indirectimplementation. This brings Pulley in line with other backends to use a fixed register for the indirect call location which is caller-save instead of possibly using a callee-save register. If a callee-save-register is used then the location to be jumped to is clobbered by register restores and won't have the correct location to jump to.This additionally required updating the Pulley ABI slightly. Previously all caller-saved registers were considered argument registers meaning that there weren't any actual available registers to use for the jump destination. To handle this I've decreased the number of argument registers by 1 so there's a single register used for the return-call-indirect destination available which is also caller-saved.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 15 2025 at 01:45):alexcrichton requested abrown for a review on PR #10021.
Wasmtime GitHub notifications bot (Jan 15 2025 at 01:45):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #10021.
Wasmtime GitHub notifications bot (Jan 15 2025 at 01:45):alexcrichton requested wasmtime-default-reviewers for a review on PR #10021.
Wasmtime GitHub notifications bot (Jan 15 2025 at 02:54):github-actions[bot] commented on PR #10021:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "fuzz-bug", "pulley"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jan 16 2025 at 17:44):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jan 16 2025 at 18:04):fitzgen merged PR #10021.
Last updated: Jan 24 2025 at 00:11 UTC