Stream: git-wasmtime

Topic: wasmtime / PR #10009 Fix dropping cached stack with `Stor...

Wasmtime GitHub notifications bot (Jan 14 2025 at 16:34):

alexcrichton requested fitzgen for a review on PR #10009.

Wasmtime GitHub notifications bot (Jan 14 2025 at 16:34):

alexcrichton opened PR #10009 from alexcrichton:flush-on-into-inner to bytecodealliance:main:

This commit fixes a regression from #9604 where using Store::into_data wouldn't properly drop a cached stack in a store like a Drop destructor. The fix here is to add the flush_fiber_stack method into the into_data here as well.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 14 2025 at 16:34):

alexcrichton requested wasmtime-core-reviewers for a review on PR #10009.

Wasmtime GitHub notifications bot (Jan 14 2025 at 16:34):

alexcrichton edited PR #10009:

This commit fixes a regression from #9604 where using Store::into_data wouldn't properly drop a cached stack in a store like a Drop destructor. The fix here is to add the flush_fiber_stack method into the into_data here as well.

Closes #10007

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 14 2025 at 19:08):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jan 14 2025 at 19:37):

alexcrichton merged PR #10009.

Last updated: Jan 24 2025 at 00:11 UTC