Stream: git-wasmtime

Topic: wasmtime / PR #10008 winch x64 rmw sub


view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:30):

MarinPostma opened PR #10008 from MarinPostma:winch-x64-rmw-sub to bytecodealliance:main:

impl read-modify-write sub for winch:

i32.atomic.rmw8.subd_u
i32.atomic.rmw16.subd_u
i32.atomic.rmw.subd
i64.atomic.rmw8.subd_u
i64.atomic.rmw16.subd_u
i64.atomic.rmw32.subd_u
i64.atomic.rmw.subd

#9734

depends on #9990

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:30):

MarinPostma requested abrown for a review on PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:30):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:30):

MarinPostma requested alexcrichton for a review on PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:30):

MarinPostma requested wasmtime-core-reviewers for a review on PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:37):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:37):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 11:39):

MarinPostma edited PR #10008:

impl read-modify-write sub for winch:

#9734

depends on #9990

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 12:53):

github-actions[bot] commented on PR #10008:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 13:48):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 13:50):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 20:57):

saulecabrera commented on PR #10008:

I'll take this one.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 14 2025 at 20:57):

saulecabrera requested saulecabrera for a review on PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2025 at 12:03):

saulecabrera commented on PR #10008:

@MarinPostma I'll take a look once this is rebased on top of https://github.com/bytecodealliance/wasmtime/pull/9990 and on top of https://github.com/bytecodealliance/wasmtime/pull/9987, since this requires using emit_compute_heap_address_align_checked

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2025 at 16:27):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2025 at 16:29):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 15 2025 at 16:46):

MarinPostma commented on PR #10008:

@saulecabrera this one is rebased too.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2025 at 00:17):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2025 at 13:56):

saulecabrera submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2025 at 13:57):

saulecabrera commented on PR #10008:

You need to rebase, since there are some conflicts.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2025 at 14:41):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2025 at 15:16):

MarinPostma updated PR #10008.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2025 at 15:31):

MarinPostma commented on PR #10008:

@saulecabrera done

view this post on Zulip Wasmtime GitHub notifications bot (Jan 16 2025 at 15:58):

saulecabrera merged PR #10008.


Last updated: Jan 24 2025 at 00:11 UTC