fitzgen requested alexcrichton for a review on PR #10002.
fitzgen requested wasmtime-core-reviewers for a review on PR #10002.
fitzgen opened PR #10002 from fitzgen:i8x16-for-v128-in-gc-objects
to bytecodealliance:main
:
We were incorrectly using
i128
previously, which would lead to invalid CLIF likeiconst.i128
when default-initializing structs and type errors when we tried to usev128
fields that we read from a struct in a SIMD instruction.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton submitted PR review.
github-actions[bot] commented on PR #10002:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
fitzgen merged PR #10002.
Last updated: Jan 24 2025 at 00:11 UTC