Wasmtime GitHub notifications bot (Mar 12 2020 at 17:11): Wasmtime GitHub notifications bot (Mar 12 2020 at 17:11):github-actions[bot] commented on Issue #819:
Subscribe to Label Action
This issue or pull request has been labeled: "w", "a", "s", "m", "t", "i", "e", ":", "p"
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Wasmtime GitHub notifications bot (Mar 12 2020 at 17:11):github-actions[bot] commented on Issue #819:
Subscribe to Label Action
This issue or pull request has been labeled: "w", "a", "s", "m", "t", "i", "e", ":", "p"
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Wasmtime GitHub notifications bot (Mar 12 2020 at 21:31):github-actions[bot] commented on Issue #819:
Subscribe to Label Action
This issue or pull request has been labeled: "wasmtime:api"
<details> <summary>Users Subscribed to "wasmtime:api"</summary>
- @peterhuene
</details>
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Wasmtime GitHub notifications bot (Mar 25 2020 at 14:14):alexcrichton commented on Issue #819:
@jlb6740 it looks like the new crate here is pulling in bindgen at build time I think, right? That's a pretty hefty dependency and one we'd ideally rather avoid. Would it be possible to check in the generated bindings from bindgen via a scheme like https://github.com/pepyakin/binaryen-rs/pull/52 perhaps?
Wasmtime GitHub notifications bot (Mar 25 2020 at 14:23):alexcrichton commented on Issue #819:
Oh as a final comment, would you be ok expanding the profiling chapter in the book that covers jitdump to cover vtune as well?
Wasmtime GitHub notifications bot (Mar 27 2020 at 07:10):jlb6740 commented on Issue #819:
Still need to update docs and follow-up on map comment.
Wasmtime GitHub notifications bot (Mar 27 2020 at 07:11):jlb6740 deleted a comment on Issue #819:
Still need to update docs and follow-up on map comment.
Wasmtime GitHub notifications bot (Mar 31 2020 at 02:34):jlb6740 commented on Issue #819:
Oh as a final comment, would you be ok expanding the profiling chapter in the book that covers jitdump to cover vtune as well?
Should be complete in the next push.
Wasmtime GitHub notifications bot (Apr 01 2020 at 20:26):github-actions[bot] commented on Issue #819:
Subscribe to Label Action
This issue or pull request has been labeled: "wasmtime:c-api", "wasmtime:docs"
<details> <summary>Users Subscribed to "wasmtime:c-api"</summary>
- @peterhuene
</details>
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Wasmtime GitHub notifications bot (Apr 01 2020 at 20:46):jlb6740 commented on Issue #819:
@alexcrichton Note, I initially delayed pushing this latest patch because I was seeing different result when processing a rust based wasm fib example compared to one compiled awhile ago with clang. The name mangling and fact that the rust based wasm file was larger and required more processing in the VM were throwing me off. More work will be needed here .... and I see feature adds like using the debug image to give vtune line number information and work to even map to the original rust or C file, but that will be iterative future work. W.r.t. this patch there may be one or two things you see so let me know and I'll be happy to update.
Wasmtime GitHub notifications bot (Apr 02 2020 at 14:04):alexcrichton commented on Issue #819:
:+1:
Last updated: Dec 23 2024 at 12:05 UTC