alexcrichton commented on Issue #2869:
Ah it looks like CI is failing when it's running the examples, as it expects that all examples pass successfully. Could the example be updated to not return a failure code? (e.g. catch the error)
Also I think our CI verifies that all examples are available in both C and Rust, so I think that at least a stub program will be needed for a C example?
ryanpbrewster commented on Issue #2869:
Ah, that could be it. Thanks for the pointer, adding a C stub now.
ryanpbrewster edited a comment on Issue #2869:
Ah, that could be it. Thanks for the pointer, adding a C stub now.
EDIT: This may take a bit, figuring out how to build and run the C examples on a mac now.
ryanpbrewster commented on Issue #2869:
Added a C example. I'm not particularly confident in the error handling and cleanup code there. I think I handle the error codes from
wasm_store_add_fuel
(and testing that if the config does not enable fuel consumption that those calls fail and exit).I'm not sure about the semantics of the
bool
thatwasm_store_fuel_consumed
returns, so I just ignored it. Should I be asserting that it's true?
ryanpbrewster edited a comment on Issue #2869:
Added a C example. I'm not particularly confident in the error handling and cleanup code there. I think I handle the error codes from
wasm_store_add_fuel
(I manually checked that if the config does not enable fuel consumption that those calls fail and exit).I'm not sure about the semantics of the
bool
thatwasm_store_fuel_consumed
returns, so I just ignored it. Should I be asserting that it's true?
alexcrichton commented on Issue #2869:
That all looks great to me, thanks!
Last updated: Dec 23 2024 at 12:05 UTC