Stream: git-wasmtime

Topic: wasmtime / Issue #2869 Add example of execution limits us...

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2021 at 17:50):

alexcrichton commented on Issue #2869:

Ah it looks like CI is failing when it's running the examples, as it expects that all examples pass successfully. Could the example be updated to not return a failure code? (e.g. catch the error)

Also I think our CI verifies that all examples are available in both C and Rust, so I think that at least a stub program will be needed for a C example?

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2021 at 18:08):

ryanpbrewster commented on Issue #2869:

Ah, that could be it. Thanks for the pointer, adding a C stub now.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2021 at 19:11):

ryanpbrewster edited a comment on Issue #2869:

Ah, that could be it. Thanks for the pointer, adding a C stub now.

EDIT: This may take a bit, figuring out how to build and run the C examples on a mac now.

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2021 at 19:36):

ryanpbrewster commented on Issue #2869:

Added a C example. I'm not particularly confident in the error handling and cleanup code there. I think I handle the error codes from wasm_store_add_fuel (and testing that if the config does not enable fuel consumption that those calls fail and exit).

I'm not sure about the semantics of the bool that wasm_store_fuel_consumed returns, so I just ignored it. Should I be asserting that it's true?

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2021 at 20:15):

ryanpbrewster edited a comment on Issue #2869:

Added a C example. I'm not particularly confident in the error handling and cleanup code there. I think I handle the error codes from wasm_store_add_fuel (I manually checked that if the config does not enable fuel consumption that those calls fail and exit).

I'm not sure about the semantics of the bool that wasm_store_fuel_consumed returns, so I just ignored it. Should I be asserting that it's true?

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2021 at 15:38):

alexcrichton commented on Issue #2869:

That all looks great to me, thanks!

Last updated: Nov 22 2024 at 16:03 UTC