Stream: git-wasmtime

Topic: wasmtime / Issue #2859 wasi-nn: turn it on by default

Wasmtime GitHub notifications bot (Apr 26 2021 at 22:59):

abrown commented on Issue #2859:

Several comments:

• the cargo-deny error is due to libloading's ISC license: is this an issue?
• in the past we had discussed enabling wasi-nn with a runtime flag (e.g., --enable-wasi-nn) but, after a discussion with @alexcrichton, it seemed to make more sense to enable it this way: the wasi_ephemeral_nn::* names are always made available by the Wasmtime engine but they only matter for users who import them.

Wasmtime GitHub notifications bot (Apr 26 2021 at 23:10):

abrown commented on Issue #2859:

• @pchickey, it would seem as though I should now be using more OS-agnostic paths to point to the WITX files to avoid this type of thing but I see in crates/wasi that you are still using the forward slash for paths--is there something I'm missing?

Wasmtime GitHub notifications bot (Apr 27 2021 at 04:13):

pchickey commented on Issue #2859:

I've never seen that error in the from_witx macro before - the same syntax is working fine in wasi-common, so I'm not sure what is up with that. I will take a look tomorrow

Wasmtime GitHub notifications bot (Apr 27 2021 at 08:55):

tschneidereit commented on Issue #2859:

The worry I'd have about enabling the wasi-nn module (or other modules somewhat early in the standardization process) is that we don't yet have a solid migration path defined. I fear that people could interpret this as a signal for more stability than we can actually guarantee right now.

The situation seems somewhat analogous to that in Node.js, where experimental JS features or Node APIs also need to be enabled explicitly, instead of just being available to content. To wit, Node has a --experimental-wasi-unstable-preview1 flag :big_smile:

For now, I'd prefer introducing a runtime flag instead of just making wasi-nn available unconditionally. Ideally not in the form of a one-off --enable-wasi-nn, but something like --experimental-wasi-modules=wasi-nn,[..].

Wasmtime GitHub notifications bot (Apr 28 2021 at 18:17):

github-actions[bot] commented on Issue #2859:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Last updated: Dec 23 2024 at 12:05 UTC