Wasmtime GitHub notifications bot (Apr 14 2021 at 23:46): Wasmtime GitHub notifications bot (Apr 14 2021 at 23:46):peterhuene commented on Issue #2842:
@alexcrichton Hopefully this didn't step on the work you were in the middle of for the feedback on #2820 (:fingers_crossed: that you hadn't started work on it before going on vacation). As I needed to refactor
StoreFrameInfointo a more general "module registry" for the signature registry changes anyway, it was pretty simple to removeStackMapRegistryentirely at that point.
Wasmtime GitHub notifications bot (Apr 14 2021 at 23:46):peterhuene edited a comment on Issue #2842:
@alexcrichton Hopefully this didn't step on the work you were in the middle of for the feedback on #2820 (:fingers_crossed: that you hadn't started work on it before going on vacation). As I needed to refactor
StoreFrameInfointo a more general "module registry" for the signature registry changes anyway, it was pretty simple to removeStackMapRegistryentirely at that point.
Wasmtime GitHub notifications bot (Apr 15 2021 at 00:15):github-actions[bot] commented on Issue #2842:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 16 2021 at 18:02):peterhuene commented on Issue #2842:
That push of the latest commit broke the build in a really strange way (as if the CI wasn't building all the changes) :oh_no:.
Wasmtime GitHub notifications bot (Apr 16 2021 at 18:07):peterhuene edited a comment on Issue #2842:
That push of the latest commit broke the build in a really strange way (as if the CI wasn't building all the changes) :oh_no:.
Oh, upstream just added a new call to initialize trap handling, noticed it on a rebase. Will fix.
Wasmtime GitHub notifications bot (Apr 16 2021 at 18:09):peterhuene edited a comment on Issue #2842:
That push of the latest commit broke the build in a really strange way (as if the CI wasn't building all the changes) :oh_no:.
Oh, upstream just added a new call to initialize trap handling, noticed it on a rebase (weird that GitHub is reporting no merge conflicts though). Will fix.
Wasmtime GitHub notifications bot (Apr 16 2021 at 18:10):peterhuene edited a comment on Issue #2842:
That push of the latest commit broke the build in a really strange way (as if the CI wasn't building all the changes) :oh_no:.
Oh, upstream just added a new call to initialize trap handling, noticed it on a rebase (weird that GitHub is reporting no merge conflicts though as I had one on the rebase). Will fix.
Wasmtime GitHub notifications bot (Apr 16 2021 at 18:19):peterhuene commented on Issue #2842:
Wouldn't the two-stage lookup suffer the same problem as we're borrowing from an interior reference of a
RefCell_optionally_, regardless of returning the module to look up the stack map for or the stack map itself?
Wasmtime GitHub notifications bot (Apr 16 2021 at 18:24):peterhuene commented on Issue #2842:
Oh I guess if it's
Arcthat's fine (no more borrow); I see how to implement this, so I'll make that change.
Wasmtime GitHub notifications bot (Apr 16 2021 at 19:32):peterhuene commented on Issue #2842:
@alexcrichton all feedback should now be addressed.
Last updated: Dec 23 2024 at 12:05 UTC