Wasmtime GitHub notifications bot (Mar 29 2021 at 16:40): Wasmtime GitHub notifications bot (Mar 29 2021 at 16:40):github-actions[bot] commented on Issue #2789:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 29 2021 at 16:51):sunfishcode commented on Issue #2789:
This looks reasonable to me. My understanding of the duplicate-imports discussion is that there are core-wasm use cases where linking based on the name identifiers alone isn't sufficient, however it also seems like core-wasm types and signatures also aren't sufficient for those use cases, because they're too low-level in general, so they'll need to do something else anyway.
Wasmtime GitHub notifications bot (Mar 29 2021 at 17:39):alexcrichton commented on Issue #2789:
Oh that reminds me of another reason to do this. Currently
Linkeris sort of a weird hybrid of trying to do name-based resolution but also doing some amount of positional-based resolution. Instead though I think it should lean one of the two directions and not try to bridge the gap which in the limit seems un-bridge-able.
Last updated: Dec 23 2024 at 12:05 UTC