Wasmtime GitHub notifications bot (Apr 07 2021 at 19:22): Wasmtime GitHub notifications bot (Apr 07 2021 at 19:22):bjorn3 commented on Issue #2786:
Writing the GOT entries needs to be delayed until after relocations have been performed and the memory has been marked as executable for code or read only for read only data.
Wasmtime GitHub notifications bot (Apr 28 2021 at 19:42):bjorn3 commented on Issue #2786:
Writing the GOT entries needs to be delayed until after relocations have been performed and the memory has been marked as executable for code or read only for read only data.
@eggyal has implemented this. Thanks!
Wasmtime GitHub notifications bot (Apr 29 2021 at 05:55):eggyal commented on Issue #2786:
I think I may have made a mess here... 3e11bd8 is undoing much of 2d9190d. While the result is that GOT updates are correctly deferred, which is what we needed for bjorn3/rustc_codegen_cranelift#1166, it likely isn't doing what's needed for hot swapping. Let me take another look.
Wasmtime GitHub notifications bot (May 10 2021 at 12:01):bjorn3 commented on Issue #2786:
I cleaned up the PR. Ready for review.
Wasmtime GitHub notifications bot (May 10 2021 at 13:54):eggyal deleted a comment on Issue #2786:
I think I may have made a mess here... 3e11bd8 is undoing much of 2d9190d. While the result is that GOT updates are correctly deferred, which is what we needed for bjorn3/rustc_codegen_cranelift#1166, it likely isn't doing what's needed for hot swapping. Let me take another look.
Last updated: Oct 23 2024 at 20:03 UTC