Stream: git-wasmtime

Topic: wasmtime / Issue #2779 Switch fuzzers to use new Cranelif...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 17:19):

github-actions[bot] commented on Issue #2779:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "fuzzing"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 17:41):

cfallin commented on Issue #2779:

Hmm, the test failure seems to indicate that the feature is leaking and turning on the new backend in other tests -- I don't claim to fully understand the new feature resolver, any thoughts @alexcrichton? Digging in further.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 18:02):

bjorn3 commented on Issue #2779:

I don't think Wasmtime has switched to the new resolver yet. You need to add

[workspace]
resolver = "2"

to the top-level Cargo.toml to enable it.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 18:04):

alexcrichton commented on Issue #2779:

Given Cargo's behavior to unify features I don't think it will be easy to have a specific default per component of wasmtime in our CI like this.

I think if we want to do this we should probably do the switch here -- https://github.com/google/oss-fuzz/blob/54f0985f8ed3055e1bbfa19eb2f67623cf952162/projects/wasmtime/build.sh#L59-L63. This would have to update that anyway since the feature is going away too.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 26 2021 at 18:10):

cfallin commented on Issue #2779:

Hmm, yes, that's probably the better option. I'll go ahead and create a PR over there. Thanks!

Last updated: Nov 22 2024 at 17:03 UTC