Wasmtime GitHub notifications bot (Mar 25 2021 at 02:38): Wasmtime GitHub notifications bot (Mar 25 2021 at 02:38):github-actions[bot] commented on Issue #2761:
Subscribe to Label Action
cc @kubkon
<details>
This issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
- kubkon: wasi
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 25 2021 at 17:50):pchickey commented on Issue #2761:
Yeah, we could do this at compile time instead of at run-time. This does add a lot of API surface but effectively its just out-lining the functionality that is already there for
add_to_config, which is implemented in terms of these new functions.I'd like to defer adding compile-time config for this for a little bit. It is an optimization, but for code should get called once per engine creation. I expect plenty more structural changes to wiggle coming down the pipe as witx and friends evolve, so I don't want to add more complexity to the macro right now if we don't have to.
Wasmtime GitHub notifications bot (Mar 25 2021 at 20:31):alexcrichton commented on Issue #2761:
Ok sounds reasonable!
Last updated: Oct 23 2024 at 20:03 UTC