Stream: git-wasmtime

Topic: wasmtime / Issue #2736 Add resource limiting to the Wasmt...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 17 2021 at 23:53):

peterhuene commented on Issue #2736:

I'm marking this as a draft PR as I'd like feedback on this approach before I create a formal RFC for the API changes (I find it useful to discuss code rather than markdown).

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 01:03):

github-actions[bot] commented on Issue #2736:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 01:42):

peterhuene commented on Issue #2736:

So I've seen this CI failure and I think it's a GitHub actions things. As far as I can tell, we're using ubuntu-latest for all of the Linux CI, but for some reason we're occasionally getting Ubuntu 20.04 instead of what should be the current latest, which is 18.04 (according to this).

Although the GitHub actions virtual environment for Ubuntu 20.04 says Clang 9 is installed, perhaps lldb-9 is not and thus the expected LLDB path set for the tests (/usr/bin/lldb-9) doesn't work.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 01:42):

peterhuene edited a comment on Issue #2736:

So I've seen this CI failure and I think it's a GitHub actions thing. As far as I can tell, we're using ubuntu-latest for all of the Linux CI, but for some reason we're occasionally getting Ubuntu 20.04 instead of what should be the current latest, which is 18.04 (according to this).

Although the GitHub actions virtual environment for Ubuntu 20.04 says Clang 9 is installed, perhaps lldb-9 is not and thus the expected LLDB path set for the tests (/usr/bin/lldb-9) doesn't work.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 01:43):

peterhuene edited a comment on Issue #2736:

So I've seen this CI failure and I think it's a GitHub actions thing. As far as I can tell, we're using ubuntu-latest for all of the Linux CI, but for some reason we're occasionally getting Ubuntu 20.04 instead of what should be the current latest, which is 18.04 (according to this):

---- debug::lldb::test_debug_dwarf_ptr stdout ----
thread 'main' panicked at 'success: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/all/debug/lldb.rs:32:31
stack backtrace:
   <snip>
   4: all::debug::lldb::lldb_with_script
             at ./tests/all/debug/lldb.rs:32:18

Although the GitHub actions virtual environment for Ubuntu 20.04 says Clang 9 is installed, perhaps lldb-9 is not and thus the expected LLDB path set for the tests (/usr/bin/lldb-9) doesn't work.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 01:44):

peterhuene edited a comment on Issue #2736:

So I've seen this CI failure and I think it's a GitHub actions thing. As far as I can tell, we're using ubuntu-latest for all of the Linux CI, but for some reason we're occasionally getting Ubuntu 20.04 instead of what should be the current latest, which is 18.04 (according to this):

---- debug::lldb::test_debug_dwarf_ptr stdout ----
thread 'main' panicked at 'success: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/all/debug/lldb.rs:32:31
stack backtrace:
   <snip>
   4: all::debug::lldb::lldb_with_script
             at ./tests/all/debug/lldb.rs:32:18

Operating System
  Ubuntu
  20.04.2
  LTS

Although the GitHub actions virtual environment for Ubuntu 20.04 says Clang 9 is installed, perhaps lldb-9 is not and thus the expected LLDB path set for the tests (/usr/bin/lldb-9) doesn't work.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 01:47):

peterhuene edited a comment on Issue #2736:

So I've seen this CI failure and I think it's a GitHub actions weirdness. As far as I can tell, we're using ubuntu-latest for all of the Linux CI, but for some reason we're occasionally getting Ubuntu 20.04 instead of what should be the current latest, which is 18.04 (according to this):

---- debug::lldb::test_debug_dwarf_ptr stdout ----
thread 'main' panicked at 'success: Os { code: 2, kind: NotFound, message: "No such file or directory" }', tests/all/debug/lldb.rs:32:31
stack backtrace:
   <snip>
   4: all::debug::lldb::lldb_with_script
             at ./tests/all/debug/lldb.rs:32:18

Operating System
  Ubuntu
  20.04.2
  LTS

Although the GitHub actions virtual environment for Ubuntu 20.04 says Clang 9 is installed, perhaps lldb-9 is not and thus the expected LLDB path set for the tests (/usr/bin/lldb-9) doesn't work.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 18:29):

peterhuene commented on Issue #2736:

So it appears that 20.04 is now ubuntu-latest by design, so we were caught in an upgrade to GitHub actions.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 18 2021 at 18:29):

peterhuene edited a comment on Issue #2736:

So it appears that 20.04 is now ubuntu-latest by design, so we were caught in an upgrade to GitHub actions.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2021 at 22:14):

github-actions[bot] commented on Issue #2736:

Subscribe to Label Action

cc @fitzgen, @peterhuene

<details>
This issue or pull request has been labeled: "fuzzing", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 02 2021 at 18:39):

peterhuene deleted a comment on Issue #2736:

I'm marking this as a draft PR as I'd like feedback on this approach before I create a formal RFC for the API changes (I find it useful to discuss code rather than markdown).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 09 2021 at 02:05):

peterhuene commented on Issue #2736:

Only the last commit is new; the rest were from your last review prior to my rebasing this branch on main.

Last updated: Dec 23 2024 at 13:07 UTC