Wasmtime GitHub notifications bot (Mar 10 2021 at 08:02): Wasmtime GitHub notifications bot (Mar 10 2021 at 08:02):cfallin commented on Issue #2718:
Switching to "Ready to Review" to get a CI run, but this should still not be merged yet.
Wasmtime GitHub notifications bot (Mar 10 2021 at 20:23):cfallin commented on Issue #2718:
Hmm -- I'm not able to reproduce the segfault with the beta toolchain; I've tested on my usual Fedora 33 and then also Ubuntu 18.04 as GitHub uses. I'm wondering if it may be either a CPU-feature issue or a heisenbug -- will continue to probe at this.
Wasmtime GitHub notifications bot (Mar 10 2021 at 20:45):bjorn3 commented on Issue #2718:
I wonder if it would be possible to get GHA to generate a core dump that could be uploaded as artifact.
Wasmtime GitHub notifications bot (Mar 26 2021 at 01:39):cfallin commented on Issue #2718:
These specify which backend to use to run the test (either new, ie "machinst", or legacy).
On Thu, Mar 25, 2021, at 18:19, Johnnie Birch wrote:
>@.**** commented on this pull request.
In cranelift/filetests/filetests/isa/x64/amode-opt.clif <https://github.com/bytecodealliance/wasmtime/pull/2718#discussion_r601946045>:
@@ -1,6 +1,5 @@
test compile
-target x86_64
-feature "experimental_x64"
+target x86_64 machinstWhat do the new file test targets (machinst and legacy) mean?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <https://github.com/bytecodealliance/wasmtime/pull/2718#pullrequestreview-621707505>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABUYVFUXNT3KK4IZAHMRO3TFPOJFANCNFSM4Y5NTKNQ>.
Wasmtime GitHub notifications bot (Mar 30 2021 at 02:16):cfallin edited a comment on Issue #2718:
On Thu, Mar 25, 2021, at 18:19, Johnnie Birch wrote:
@.**** commented on this pull request.
In cranelift/filetests/filetests/isa/x64/amode-opt.clif <https://github.com/bytecodealliance/wasmtime/pull/2718#discussion_r601946045>:
@@ -1,6 +1,5 @@
test compile
-target x86_64
-feature "experimental_x64"
+target x86_64 machinstWhat do the new file test targets (machinst and legacy) mean?
These specify which backend to use to run the test (either new, ie "machinst", or legacy).
Wasmtime GitHub notifications bot (Mar 30 2021 at 21:32):cfallin commented on Issue #2718:
Rebased to latest. The current plan described in the recently merged bytecodealliance/rfcs#10 is to:
- Wait until next week as the oss-fuzz fuzzers run with the new backend enabled (turned on in google/oss-fuzz#5518).
- Make a final release of wasmtime/Cranelift with the current (old) default backend.
- Review and merge this PR.
Wasmtime GitHub notifications bot (Mar 31 2021 at 14:20):alexcrichton commented on Issue #2718:
FWIW the fuzzers are definitely working because they already fixed a fuzz bug that was about a timeout in the old backend. Our of curiosity is there any particular reason to wait for one more release rather than considering the last release of wasmtime the last release with the old backend as the default?
Wasmtime GitHub notifications bot (Mar 31 2021 at 17:01):cfallin commented on Issue #2718:
That's a good question -- the intent in the RFC was to have a latest-possible snapshot with as many features as possible supported on the old backend with the old backend on by default. Looking through the PR history since 0.25.0, though, it doesn't look like we landed any major user-visible feature, except for some things (SIMD tidbits on new x64 backend, macOS/aarch64) that are not relevant if one is using the old backend. (Please do let me know if I've missed something!)
Given that, I think it fits the spirit of the transition plan in the RFC to take 0.25.0 as the last-good old-backend-as-default release, and just merge this after a bit more fuzzing time. Curious what others think, of course!
Wasmtime GitHub notifications bot (Apr 05 2021 at 16:38):cfallin commented on Issue #2718:
So there have been no fuzzbugs related to the new backend since we switched the fuzzers over; as per the above, I think this means we're ready to switch the default! Merging now.
Last updated: Nov 22 2024 at 17:03 UTC