Wasmtime GitHub notifications bot (Mar 04 2021 at 22:31): Wasmtime GitHub notifications bot (Mar 04 2021 at 22:31):alexcrichton commented on Issue #2707:
I think it's fine to have a release of wamtime, but for this problem specifically it seems like the best solution would be to yank the versions of crates on crates.io that have the breaking change? That would keep wasmtime-working as-is (and anyone else depending on the crates)
Wasmtime GitHub notifications bot (Mar 04 2021 at 22:51):bnjbvr commented on Issue #2707:
I don't have an opinion on the right way to fix the semver issue above, but if this wasn't too much burden, it would be pretty nice to have a release that contained the fix provided in https://github.com/bytecodealliance/wasmtime/pull/2664 (this new released version would be the first one to include it).
Wasmtime GitHub notifications bot (Mar 04 2021 at 23:37):github-actions[bot] commented on Issue #2707:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:peepmatic", "cranelift:meta", "cranelift:module", "cranelift:wasm", "wasmtime:docs"Thus the following users have been cc'd because of the following labels:
- fitzgen: cranelift:area:peepmatic
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Mar 05 2021 at 02:08):sunfishcode commented on Issue #2707:
Sounds like we should do both then. I'll figure out exactly what needs to be yanked, but since I already have this PR ready to go, we can also do a release. Anyone want to approve this PR? :-)
Last updated: Dec 23 2024 at 12:05 UTC