Stream: git-wasmtime

Topic: wasmtime / Issue #2659 Update to the next version of the ...


view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 18:53):

alexcrichton commented on Issue #2659:

Oh and one other change with this PR, some errors which were previously classified as EINVAL or similar are now classified as traps. For example if you return a bad return pointer and we fail trying to write to it we'll generate a trap instead of returning EINVAL.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 19:16):

github-actions[bot] commented on Issue #2659:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 19:52):

abrown commented on Issue #2659:

Looks like https://github.com/bytecodealliance/wasmtime/pull/2659/checks?check_run_id=1921259948 is the same type of error that I saw in @sunfishcode's PR... I told him that I am willing to take a look at upgrading the witx for wasi-nn but that may not be the only thing going wrong here. Let me know if you need me to take a look.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 17 2021 at 21:47):

alexcrichton commented on Issue #2659:

@abrown no worries, I'll probably need to send a merge change to the wasi-nn repo once the wasi changes land which updates the witx as well. I don't mind doing that inline here as well.

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 18:03):

alexcrichton commented on Issue #2659:

Ok all submodules have been merged and this is now updated, so this is ready for merge when approved

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 20:24):

jedisct1 commented on Issue #2659:

Looking good!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 18 2021 at 22:45):

abrown commented on Issue #2659:

And thanks @alexcrichton for the changes to wasi-nn as well!


Last updated: Dec 23 2024 at 12:05 UTC