Stream: git-wasmtime

Topic: wasmtime / Issue #2655 Fix warnings (causing CI failures)...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 16:42):

alexcrichton commented on Issue #2655:

I think a number of the panic/format-related message warnings were fixed in https://github.com/bytecodealliance/wasmtime/pull/2652, but the other changes look good here! Want to update the rand crate as well to fix the cargo deny error?

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 16:51):

cfallin commented on Issue #2655:

Ah yes, updated for cargo-deny as well, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 16:53):

cfallin commented on Issue #2655:

Hmm, now cargo-audit is unhappy but it's unclear where the old rand_core is coming from -- investigating...

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 17:06):

cfallin commented on Issue #2655:

OK, so removing Cargo.lock and attempting a rebuild runs into some errors in bitvec conflicting with funty (both have traits that define a BITS associated constant and there's a resolution conflict). This is getting... exciting. I'm not sure how to proceed generating a fresh Cargo.lock without opening some PRs upstream.

If I try to just trim our Cargo.lock in a more scoped way, I see that the bad version rand_core 0.5.1 is used by wasi-crypto. @sunfishcode or @pchickey, thoughts on this?

(Separately, I have some concerns about random CI breakages that require upstream fixes and cause our work to halt -- do we want to talk about whether cargo-audit / cargo-deny should be warnings-we-address-ASAP rather than red-CI-errors? Are there compliance reasons they have to be the latter? @tschneidereit thoughts?)

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 17:50):

github-actions[bot] commented on Issue #2655:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:peepmatic", "cranelift:meta", "cranelift:wasm"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Feb 16 2021 at 20:15):

cfallin commented on Issue #2655:

Closing as #2656 incorporates these fixes along with fixes for the cargo-audit reports.

Last updated: Nov 22 2024 at 17:03 UTC