Wasmtime GitHub notifications bot (Feb 03 2021 at 20:58): Wasmtime GitHub notifications bot (Feb 03 2021 at 20:58):alexcrichton commented on Issue #2632:
One thing worth pointing out is that I believe Wasmtime currently complies for arm64 macOS (although it doesn't work AFAIK), but this PR would break that. Structures for the thread state would need to be copied over from various headers to get that working.
Wasmtime GitHub notifications bot (Feb 03 2021 at 21:25):Jake-Shadle commented on Issue #2632:
We actually run aarch64 mac CI on our project that uses wasmtime, so I think we can just add a PR that builds off of this one for the aarch64 specific things that would need to change. :slightly_smiling_face:
Wasmtime GitHub notifications bot (Feb 03 2021 at 21:29):Jake-Shadle commented on Issue #2632:
Oh wait, I was just reminded that we _might_ not be able to verify this PR on the aarch64 mac though, due to https://github.com/bytecodealliance/wasmtime/issues/2552, we actually had to disable the tests we had that purposefully paniced inside the wasm module for aarch64 mac due to it actually crashing our host program.
Wasmtime GitHub notifications bot (Feb 03 2021 at 21:53):github-actions[bot] commented on Issue #2632:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 03 2021 at 22:18):alexcrichton commented on Issue #2632:
Ah ok, I didn't realize it already worked well enough to at least have some testing! I've pushed up https://github.com/bytecodealliance/wasmtime/pull/2632/commits/d07d29b83f92a66c761fc9f207f93a60e3f7562e although it is entirely untested on my end (I don't have arm64 hardware). It should compile but I suspect at least some tests fail.
Wasmtime GitHub notifications bot (Feb 04 2021 at 07:09):Jake-Shadle commented on Issue #2632:
Great, thanks!
Wasmtime GitHub notifications bot (Mar 17 2021 at 09:35):bnjbvr commented on Issue #2632:
I've based my work in #2723 from this PR, which has been rebased and tweaked. Thanks a lot @alexcrichton for all the initial work on this!
Last updated: Nov 22 2024 at 16:03 UTC